Skip to content

fix: make curl requests failsafe against redirects, return error on fail #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vsoch merged 2 commits into from
Dec 13, 2025
Merged

fix: make curl requests failsafe against redirects, return error on fail #229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7dfdfcd
fix: make curl requests failsafe against redirects, return error on fail
m-jahn Dec 12, 2025
0ec6220
fix: changelog and version
m-jahn Dec 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ The client here will eventually be released as "spython" (and eventually to
singularity on pypi), and the versions here will coincide with these releases.

## [master](https://github.com/singularityhub/singularity-cli/tree/master)
- make curl requests failsafe against redirects, improved error on fail (0.3.15)
- add stream_type to 'run' command like in 'exec' (0.3.14)
- do not modify user provided instance name when generating new instance (0.3.13)
- bug with instance.run_command (0.3.12)
Expand Down
3 changes: 2 additions & 1 deletion spython/main/parse/parsers/docker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,7 +332,8 @@ def _parse_http(self, url, dest):
"""
file_name = os.path.basename(url)
download_path = "%s/%s" % (dest, file_name)
command = "curl %s -o %s" % (url, download_path)
curl_flags = "-L --retry 1 --fail --show-error"
command = "curl %s %s -o %s" % (curl_flags, url, download_path)
self.recipe[self.active_layer].install.append(command)

def _parse_archive(self, targz, dest):
Expand Down
2 changes: 1 addition & 1 deletion spython/version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
# with this file, You can obtain one at http://mozilla.org/MPL/2.0/.


__version__ = "0.3.14"
__version__ = "0.3.15"
AUTHOR = "Vanessa Sochat"
AUTHOR_EMAIL = "[email protected]"
NAME = "spython"
Expand Down