fix(repo): patch npm-run-all to detect cjs npm exec paths#2810
Open
better-salmon wants to merge 1 commit into
Open
fix(repo): patch npm-run-all to detect cjs npm exec paths#2810better-salmon wants to merge 1 commit into
better-salmon wants to merge 1 commit into
Conversation
pnpm 11 exposes npm_execpath as pnpm.cjs, but npm-run-all only treated .js/.mjs paths as Node shims. It tried to execute pnpm.cjs directly and hit EACCES, so the patch treats .cjs as a JS shim and runs it through node.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pnpmmanaged byvite-pluscauses this error:In this particular setup
pnpm 11exposesnpm_execpathaspnpm.cjs. Butnpm-run-allonly treated.js/.mjspaths as Node shims. It tried to executepnpm.cjsdirectly and hitEACCES, so the patch treats.cjsas a JS shim and runs it throughnode.Updating
pnpmto 11.9.0 did not help.How did you test this change?
pnpm buildnow works. The patch is minimal and sufficient.