Skip to content

fix(repo): patch npm-run-all to detect cjs npm exec paths #2810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
better-salmon wants to merge 1 commit into from
+21 −2
Closed

fix(repo): patch npm-run-all to detect cjs npm exec paths #2810

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions patches/npm-run-all@4.1.5.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
diff --git a/lib/run-task.js b/lib/run-task.js
index 8cabc03c7ef64f5ca57378009618222fc97ac9b7..53166e6a81a1fb5dfcf0c489ef5815f864f80a13 100644
--- a/lib/run-task.js
+++ b/lib/run-task.js
@@ -155,7 +155,7 @@ module.exports = function runTask(task, options) {

// Execute.
const npmPath = options.npmPath || process.env.npm_execpath //eslint-disable-line no-process-env
- const npmPathIsJs = typeof npmPath === "string" && /\.m?js/.test(path.extname(npmPath))
+ const npmPathIsJs = typeof npmPath === "string" && /^\.[cm]?js$/.test(path.extname(npmPath))
const execPath = (npmPathIsJs ? process.execPath : npmPath || "npm")
const isYarn = path.basename(npmPath || "npm").startsWith("yarn")
const spawnArgs = ["run"]
7 changes: 5 additions & 2 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions pnpm-workspace.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ allowBuilds:
esbuild: true
simple-git-hooks: true

patchedDependencies:
npm-run-all@4.1.5: patches/npm-run-all@4.1.5.patch

minimumReleaseAgeExclude:
- babel-plugin-jsx-dom-expressions
- dom-expressions
Expand Down