Fix buffer leak in RSocket SETUP frame handling - #37105
Closed
yashsiwacha wants to merge 1 commit into
Closed
Conversation
Remove the explicit `payload.retain()` call in `MessagingRSocket#handleConnectionSetupPayload` because the setup payload is fully owned by the SocketAcceptor, and `MessagingRSocket#handle` properly strips metadata, wraps the data in a DataBuffer, and eventually releases the initial buffer. The extra `.retain()` caused the underlying Netty buffer reference count to drop to 1 rather than 0 on success. Additionally, handle early failures in `RSocketMessageHandler#responder` by releasing the connection setup payload explicitly if responder creation fails (e.g. invalid mime types). Issue: spring-projects#37026 Signed-off-by: Yash Siwach <yashsiwach07@gmail.com>
yashsiwacha
force-pushed
the
fix/issue-37026-rsocket-buffer-leak
branch
from
August 3, 2026 10:42
93da4c5 to
2579793
Compare
Member
|
Thanks but this was already assigned. |
bclozel
added
the
status: declined
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the explicit
payload.retain()call inMessagingRSocket#handleConnectionSetupPayloadbecause the setup payload is fully owned by the SocketAcceptor, andMessagingRSocket#handleproperly strips metadata, wraps the data in a DataBuffer, and eventually releases the initial buffer. The extra.retain()caused the underlying Netty buffer reference count to drop to 1 rather than 0 on success.Additionally, handle early failures in
RSocketMessageHandler#responderby releasing the connection setup payload explicitly if responder creation fails (e.g. invalid mime types).Issue: #37026