Skip to content

Fix buffer leak in RSocket SETUP frame handling #37105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yashsiwacha wants to merge 1 commit into from
+1 −3
Closed

Fix buffer leak in RSocket SETUP frame handling #37105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .../main/java/org/springframework/messaging/rsocket/annotation/support/MessagingRSocket.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,9 +103,6 @@ class MessagingRSocket implements RSocket {
* @return completion handle for success or error
*/
public Mono<Void> handleConnectionSetupPayload(ConnectionSetupPayload payload) {
// frameDecoder does not apply to connectionSetupPayload
// so retain here since handle expects it.
payload.retain();
return handle(payload, FrameType.SETUP);
}

Expand Down
1 change: 1 addition & 0 deletions .../java/org/springframework/messaging/rsocket/annotation/support/RSocketMessageHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -425,6 +425,7 @@ public SocketAcceptor responder() {
responder = createResponder(setupPayload, sendingRSocket);
}
catch (Throwable ex) {
setupPayload.release();
return Mono.error(ex);
}
return responder.handleConnectionSetupPayload(setupPayload).then(Mono.just(responder));
Expand Down