[auth] Auto-generate nonce when caller does not provide one#273
Draft
partha-uber wants to merge 3 commits into
Draft
[auth] Auto-generate nonce when caller does not provide one#273partha-uber wants to merge 3 commits into
partha-uber wants to merge 3 commits into
Conversation
Summary: - SDK now auto-generates a cryptographically secure `nonce` parameter (SecureRandom, 32 bytes, base64url) when `AuthContext.nonce` is null - `effectiveNonce = authContext.nonce ?: generateSecureToken()` ensures nonce is always present in SSO query params for replay attack prevention - Callers that supply their own nonce (for backend binding) are unaffected - `@VisibleForTesting effectiveNonce` field exposed for assertions This is step 2/3 of iOS parity (PR #337 in uber-ios-sdk).
Summary: - Verify PKCE flow also forwards the auto-generated nonce - Verify two different AuthProvider instances produce distinct nonces (randomness sanity check) - Verify effectiveNonce field is stable on repeated reads
This was referenced Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nonceparameter(SecureRandom, 32 bytes, base64url) when
AuthContext.nonceis nulleffectiveNonce = authContext.nonce ?: generateSecureToken()ensuresnonce is always present in SSO query params for replay attack prevention
@VisibleForTesting effectiveNoncefield exposed for assertionsThis is step 2/3 of iOS parity (PR #337 in uber-ios-sdk).
Test Plan
Issues
Stack