[auth] Add id_token field to UberToken and validate nonce claim#274
Draft
partha-uber wants to merge 2 commits into
Draft
[auth] Add id_token field to UberToken and validate nonce claim#274partha-uber wants to merge 2 commits into
partha-uber wants to merge 2 commits into
Conversation
This was referenced Jun 17, 2026
Summary: - `UberToken` gains `@Json(name = "id_token") val idToken: String?` for OIDC id_token deserialization - `AuthException.NONCE_MISMATCH` constant added for replay-attack detection - `performPkce` validates the `nonce` claim in `id_token` against `effectiveNonce`; returns `NONCE_MISMATCH` error on mismatch - `extractNonceFromIdToken` decodes the JWT payload (base64url) and extracts the `nonce` claim via `org.json.JSONObject` — no extra libs - Validation is skipped when server returns no `id_token` (backward compat) This is step 3/3 of iOS parity (PR #337 in uber-ios-sdk).
partha-uber
force-pushed
the
sirker-auth-nonce-idtoken
branch
from
0685a42 to
17d60b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UberTokengains@Json(name = "id_token") val idToken: String?forOIDC id_token deserialization
AuthException.NONCE_MISMATCHconstant added for replay-attack detectionperformPkcevalidates thenonceclaim inid_tokenagainsteffectiveNonce; returnsNONCE_MISMATCHerror on mismatchextractNonceFromIdTokendecodes the JWT payload (base64url) andextracts the
nonceclaim viaorg.json.JSONObject— no extra libsid_token(backward compat)This is step 3/3 of iOS parity (PR #337 in uber-ios-sdk).
Test Plan
Issues
Stack