Hi! This PR fixes an issue where alpha values less than 1 (such as 0.05) would generate a single-character hex representation for the alpha channel (e.g., d instead of 0d). This resulted in an invalid 7-character hex string which broke background transparency when opening new windows or restarting the application. I solved this by adding .padStart(2, '0') to the alphaHex generation in to-electron-background-color.ts to guarantee a valid 8-character hex output. Closes #2847fix: pad single-character hex values in electron background color#8200
Open
OzkurtSelcuk wants to merge 1 commit into
Open
Hi! This PR fixes an issue where alpha values less than 1 (such as 0.05) would generate a single-character hex representation for the alpha channel (e.g., d instead of 0d). This resulted in an invalid 7-character hex string which broke background transparency when opening new windows or restarting the application. I solved this by adding .padStart(2, '0') to the alphaHex generation in to-electron-background-color.ts to guarantee a valid 8-character hex output. Closes #2847fix: pad single-character hex values in electron background color#8200OzkurtSelcuk wants to merge 1 commit into
d instead of 0d). This resulted in an invalid 7-character hex string which broke background transparency when opening new windows or restarting the application. I solved this by adding .padStart(2, '0') to the alphaHex generation in to-electron-background-color.ts to guarantee a valid 8-character hex output. Closes #2847fix: pad single-character hex values in electron background color#8200OzkurtSelcuk wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.