Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! This PR fixes an issue where alpha values less than 1 (such as 0.05) would generate a single-character hex representation for the alpha channel (e.g.,
dinstead of0d). This resulted in an invalid 7-character hex string which broke background transparency when opening new windows or restarting the application. I solved this by adding.padStart(2, '0')to thealphaHexgeneration into-electron-background-color.tsto guarantee a valid 8-character hex output. Closes #2847fix: pad single-character hex values in electron background color #8200New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: canary
Are you sure you want to change the base?
Hi! This PR fixes an issue where alpha values less than 1 (such as 0.05) would generate a single-character hex representation for the alpha channel (e.g.,
dinstead of0d). This resulted in an invalid 7-character hex string which broke background transparency when opening new windows or restarting the application. I solved this by adding.padStart(2, '0')to thealphaHexgeneration into-electron-background-color.tsto guarantee a valid 8-character hex output. Closes #2847fix: pad single-character hex values in electron background color #8200Changes from all commits
5063188File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing