Skip to content

scalar_at take execution_ctx#7166

Merged
a10y merged 2 commits intodevelopfrom
aduffy/scalar_at
Mar 26, 2026
Merged

scalar_at take execution_ctx#7166
a10y merged 2 commits intodevelopfrom
aduffy/scalar_at

Conversation

@a10y
Copy link
Contributor

@a10y a10y commented Mar 25, 2026

Summary

This updates the OperationsVTable to inject an execution context for scalar_at.

This will allow the PatchedArray to execute a range of its indices child for linear search instead of issuing a scalar_at and cast in a loop.

@a10y a10y requested a review from gatesn March 25, 2026 20:58
@a10y a10y added the changelog/chore A trivial change label Mar 25, 2026
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 25, 2026

Merging this PR will degrade performance by 16%

⚡ 2 improved benchmarks
❌ 3 regressed benchmarks
✅ 1101 untouched benchmarks
⏩ 1522 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation case_when_all_false[1000] 129.8 µs 108.7 µs +19.44%
Simulation case_when_fragmented[100] 149.2 µs 167.6 µs -10.98%
Simulation scalar_at_struct_wide 2.9 ms 3.4 ms -16%
Simulation scalar_at_struct_simple 645.7 µs 759.5 µs -14.98%
Simulation decompress_alp[f32, (1000, 0.0, 1.0)] 10 µs 9 µs +11.9%

Comparing aduffy/scalar_at (09ae39e) with develop (7aa556a)2

Open in CodSpeed

Footnotes

  1. 1522 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on develop (8b83d7b) during the generation of this report, so 7aa556a was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@a10y a10y force-pushed the aduffy/scalar_at branch from ae350d3 to 8daa260 Compare March 26, 2026 18:43
@a10y a10y enabled auto-merge (squash) March 26, 2026 18:43
a10y added 2 commits March 26, 2026 14:50
Signed-off-by: Andrew Duffy <andrew@a10y.dev>
due to upstream parking_lot issue

Signed-off-by: Andrew Duffy <andrew@a10y.dev>
@a10y a10y force-pushed the aduffy/scalar_at branch from 8daa260 to 09ae39e Compare March 26, 2026 18:50
@a10y a10y merged commit fa6931a into develop Mar 26, 2026
111 of 114 checks passed
@a10y a10y deleted the aduffy/scalar_at branch March 26, 2026 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants