Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions encodings/alp/public-api.lock
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ pub fn vortex_alp::ALP::with_children(array: &mut Self::Array, children: alloc::

impl vortex_array::vtable::operations::OperationsVTable<vortex_alp::ALP> for vortex_alp::ALP

pub fn vortex_alp::ALP::scalar_at(array: &vortex_alp::ALPArray, index: usize) -> vortex_error::VortexResult<vortex_array::scalar::Scalar>
pub fn vortex_alp::ALP::scalar_at(array: &vortex_alp::ALPArray, index: usize, _ctx: &mut vortex_array::executor::ExecutionCtx) -> vortex_error::VortexResult<vortex_array::scalar::Scalar>

impl vortex_array::vtable::validity::ValidityChild<vortex_alp::ALP> for vortex_alp::ALP

Expand Down Expand Up @@ -266,7 +266,7 @@ pub fn vortex_alp::ALPRD::with_children(array: &mut Self::Array, children: alloc

impl vortex_array::vtable::operations::OperationsVTable<vortex_alp::ALPRD> for vortex_alp::ALPRD

pub fn vortex_alp::ALPRD::scalar_at(array: &vortex_alp::ALPRDArray, index: usize) -> vortex_error::VortexResult<vortex_array::scalar::Scalar>
pub fn vortex_alp::ALPRD::scalar_at(array: &vortex_alp::ALPRDArray, index: usize, _ctx: &mut vortex_array::executor::ExecutionCtx) -> vortex_error::VortexResult<vortex_array::scalar::Scalar>

impl vortex_array::vtable::validity::ValidityChild<vortex_alp::ALPRD> for vortex_alp::ALPRD

Expand Down
3 changes: 2 additions & 1 deletion encodings/alp/src/alp/ops.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
// SPDX-License-Identifier: Apache-2.0
// SPDX-FileCopyrightText: Copyright the Vortex contributors

use vortex_array::ExecutionCtx;
use vortex_array::scalar::Scalar;
use vortex_array::vtable::OperationsVTable;
use vortex_error::VortexExpect;
Expand All @@ -12,7 +13,7 @@ use crate::ALPFloat;
use crate::match_each_alp_float_ptype;

impl OperationsVTable<ALP> for ALP {
fn scalar_at(array: &ALPArray, index: usize) -> VortexResult<Scalar> {
fn scalar_at(array: &ALPArray, index: usize, _ctx: &mut ExecutionCtx) -> VortexResult<Scalar> {
if let Some(patches) = array.patches()
&& let Some(patch) = patches.get_patched(index)?
{
Expand Down
7 changes: 6 additions & 1 deletion encodings/alp/src/alp_rd/ops.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
// SPDX-FileCopyrightText: Copyright the Vortex contributors

use vortex_array::DynArray;
use vortex_array::ExecutionCtx;
use vortex_array::scalar::Scalar;
use vortex_array::vtable::OperationsVTable;
use vortex_error::VortexExpect;
Expand All @@ -11,7 +12,11 @@ use crate::ALPRD;
use crate::ALPRDArray;

impl OperationsVTable<ALPRD> for ALPRD {
fn scalar_at(array: &ALPRDArray, index: usize) -> VortexResult<Scalar> {
fn scalar_at(
array: &ALPRDArray,
index: usize,
_ctx: &mut ExecutionCtx,
) -> VortexResult<Scalar> {
// The left value can either be a direct value, or an exception.
// The exceptions array represents exception positions with non-null values.
let maybe_patched_value = match array.left_parts_patches() {
Expand Down
2 changes: 1 addition & 1 deletion encodings/bytebool/public-api.lock
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ pub fn vortex_bytebool::ByteBool::with_children(array: &mut Self::Array, childre

impl vortex_array::vtable::operations::OperationsVTable<vortex_bytebool::ByteBool> for vortex_bytebool::ByteBool

pub fn vortex_bytebool::ByteBool::scalar_at(array: &vortex_bytebool::ByteBoolArray, index: usize) -> vortex_error::VortexResult<vortex_array::scalar::Scalar>
pub fn vortex_bytebool::ByteBool::scalar_at(array: &vortex_bytebool::ByteBoolArray, index: usize, _ctx: &mut vortex_array::executor::ExecutionCtx) -> vortex_error::VortexResult<vortex_array::scalar::Scalar>

pub struct vortex_bytebool::ByteBoolArray

Expand Down
6 changes: 5 additions & 1 deletion encodings/bytebool/src/array.rs
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,11 @@ impl ValidityHelper for ByteBoolArray {
}

impl OperationsVTable<ByteBool> for ByteBool {
fn scalar_at(array: &ByteBoolArray, index: usize) -> VortexResult<Scalar> {
fn scalar_at(
array: &ByteBoolArray,
index: usize,
_ctx: &mut ExecutionCtx,
) -> VortexResult<Scalar> {
Ok(Scalar::bool(
array.buffer.as_host()[index] == 1,
array.dtype().nullability(),
Expand Down
2 changes: 1 addition & 1 deletion encodings/datetime-parts/public-api.lock
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ pub fn vortex_datetime_parts::DateTimeParts::with_children(array: &mut Self::Arr

impl vortex_array::vtable::operations::OperationsVTable<vortex_datetime_parts::DateTimeParts> for vortex_datetime_parts::DateTimeParts

pub fn vortex_datetime_parts::DateTimeParts::scalar_at(array: &vortex_datetime_parts::DateTimePartsArray, index: usize) -> vortex_error::VortexResult<vortex_array::scalar::Scalar>
pub fn vortex_datetime_parts::DateTimeParts::scalar_at(array: &vortex_datetime_parts::DateTimePartsArray, index: usize, _ctx: &mut vortex_array::executor::ExecutionCtx) -> vortex_error::VortexResult<vortex_array::scalar::Scalar>

impl vortex_array::vtable::validity::ValidityChild<vortex_datetime_parts::DateTimeParts> for vortex_datetime_parts::DateTimeParts

Expand Down
7 changes: 6 additions & 1 deletion encodings/datetime-parts/src/ops.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
// SPDX-FileCopyrightText: Copyright the Vortex contributors

use vortex_array::DynArray;
use vortex_array::ExecutionCtx;
use vortex_array::dtype::DType;
use vortex_array::extension::datetime::Timestamp;
use vortex_array::scalar::Scalar;
Expand All @@ -16,7 +17,11 @@ use crate::timestamp;
use crate::timestamp::TimestampParts;

impl OperationsVTable<DateTimeParts> for DateTimeParts {
fn scalar_at(array: &DateTimePartsArray, index: usize) -> VortexResult<Scalar> {
fn scalar_at(
array: &DateTimePartsArray,
index: usize,
_ctx: &mut ExecutionCtx,
) -> VortexResult<Scalar> {
let DType::Extension(ext) = array.dtype().clone() else {
vortex_panic!(
"DateTimePartsArray must have extension dtype, found {}",
Expand Down
2 changes: 1 addition & 1 deletion encodings/decimal-byte-parts/public-api.lock
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ pub fn vortex_decimal_byte_parts::DecimalByteParts::with_children(array: &mut Se

impl vortex_array::vtable::operations::OperationsVTable<vortex_decimal_byte_parts::DecimalByteParts> for vortex_decimal_byte_parts::DecimalByteParts

pub fn vortex_decimal_byte_parts::DecimalByteParts::scalar_at(array: &vortex_decimal_byte_parts::DecimalBytePartsArray, index: usize) -> vortex_error::VortexResult<vortex_array::scalar::Scalar>
pub fn vortex_decimal_byte_parts::DecimalByteParts::scalar_at(array: &vortex_decimal_byte_parts::DecimalBytePartsArray, index: usize, _ctx: &mut vortex_array::executor::ExecutionCtx) -> vortex_error::VortexResult<vortex_array::scalar::Scalar>

impl vortex_array::vtable::validity::ValidityChild<vortex_decimal_byte_parts::DecimalByteParts> for vortex_decimal_byte_parts::DecimalByteParts

Expand Down
6 changes: 5 additions & 1 deletion encodings/decimal-byte-parts/src/decimal_byte_parts/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,11 @@ fn to_canonical_decimal(
}

impl OperationsVTable<DecimalByteParts> for DecimalByteParts {
fn scalar_at(array: &DecimalBytePartsArray, index: usize) -> VortexResult<Scalar> {
fn scalar_at(
array: &DecimalBytePartsArray,
index: usize,
_ctx: &mut ExecutionCtx,
) -> VortexResult<Scalar> {
// TODO(joe): support parts len != 1
let scalar = array.msp.scalar_at(index)?;

Expand Down
8 changes: 4 additions & 4 deletions encodings/fastlanes/public-api.lock
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ pub fn vortex_fastlanes::BitPacked::with_children(array: &mut Self::Array, child

impl vortex_array::vtable::operations::OperationsVTable<vortex_fastlanes::BitPacked> for vortex_fastlanes::BitPacked

pub fn vortex_fastlanes::BitPacked::scalar_at(array: &vortex_fastlanes::BitPackedArray, index: usize) -> vortex_error::VortexResult<vortex_array::scalar::Scalar>
pub fn vortex_fastlanes::BitPacked::scalar_at(array: &vortex_fastlanes::BitPackedArray, index: usize, _ctx: &mut vortex_array::executor::ExecutionCtx) -> vortex_error::VortexResult<vortex_array::scalar::Scalar>

pub struct vortex_fastlanes::BitPackedArray

Expand Down Expand Up @@ -356,7 +356,7 @@ pub fn vortex_fastlanes::Delta::with_children(array: &mut Self::Array, children:

impl vortex_array::vtable::operations::OperationsVTable<vortex_fastlanes::Delta> for vortex_fastlanes::Delta

pub fn vortex_fastlanes::Delta::scalar_at(array: &vortex_fastlanes::DeltaArray, index: usize) -> vortex_error::VortexResult<vortex_array::scalar::Scalar>
pub fn vortex_fastlanes::Delta::scalar_at(array: &vortex_fastlanes::DeltaArray, index: usize, _ctx: &mut vortex_array::executor::ExecutionCtx) -> vortex_error::VortexResult<vortex_array::scalar::Scalar>

impl vortex_array::vtable::validity::ValidityVTable<vortex_fastlanes::Delta> for vortex_fastlanes::Delta

Expand Down Expand Up @@ -502,7 +502,7 @@ pub fn vortex_fastlanes::FoR::with_children(array: &mut Self::Array, children: a

impl vortex_array::vtable::operations::OperationsVTable<vortex_fastlanes::FoR> for vortex_fastlanes::FoR

pub fn vortex_fastlanes::FoR::scalar_at(array: &vortex_fastlanes::FoRArray, index: usize) -> vortex_error::VortexResult<vortex_array::scalar::Scalar>
pub fn vortex_fastlanes::FoR::scalar_at(array: &vortex_fastlanes::FoRArray, index: usize, _ctx: &mut vortex_array::executor::ExecutionCtx) -> vortex_error::VortexResult<vortex_array::scalar::Scalar>

impl vortex_array::vtable::validity::ValidityChild<vortex_fastlanes::FoR> for vortex_fastlanes::FoR

Expand Down Expand Up @@ -632,7 +632,7 @@ pub fn vortex_fastlanes::RLE::with_children(array: &mut Self::Array, children: a

impl vortex_array::vtable::operations::OperationsVTable<vortex_fastlanes::RLE> for vortex_fastlanes::RLE

pub fn vortex_fastlanes::RLE::scalar_at(array: &vortex_fastlanes::RLEArray, index: usize) -> vortex_error::VortexResult<vortex_array::scalar::Scalar>
pub fn vortex_fastlanes::RLE::scalar_at(array: &vortex_fastlanes::RLEArray, index: usize, _ctx: &mut vortex_array::executor::ExecutionCtx) -> vortex_error::VortexResult<vortex_array::scalar::Scalar>

impl vortex_array::vtable::validity::ValidityChild<vortex_fastlanes::RLE> for vortex_fastlanes::RLE

Expand Down
7 changes: 6 additions & 1 deletion encodings/fastlanes/src/bitpacking/vtable/operations.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
// SPDX-License-Identifier: Apache-2.0
// SPDX-FileCopyrightText: Copyright the Vortex contributors

use vortex_array::ExecutionCtx;
use vortex_array::scalar::Scalar;
use vortex_array::vtable::OperationsVTable;
use vortex_error::VortexResult;
Expand All @@ -10,7 +11,11 @@ use crate::BitPackedArray;
use crate::bitpack_decompress;

impl OperationsVTable<BitPacked> for BitPacked {
fn scalar_at(array: &BitPackedArray, index: usize) -> VortexResult<Scalar> {
fn scalar_at(
array: &BitPackedArray,
index: usize,
_ctx: &mut ExecutionCtx,
) -> VortexResult<Scalar> {
Ok(
if let Some(patches) = array.patches()
&& let Some(patch) = patches.get_patched(index)?
Expand Down
7 changes: 6 additions & 1 deletion encodings/fastlanes/src/delta/vtable/operations.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
// SPDX-License-Identifier: Apache-2.0
// SPDX-FileCopyrightText: Copyright the Vortex contributors

use vortex_array::ExecutionCtx;
use vortex_array::ToCanonical;
use vortex_array::scalar::Scalar;
use vortex_array::vtable::OperationsVTable;
Expand All @@ -10,7 +11,11 @@ use super::Delta;
use crate::DeltaArray;

impl OperationsVTable<Delta> for Delta {
fn scalar_at(array: &DeltaArray, index: usize) -> VortexResult<Scalar> {
fn scalar_at(
array: &DeltaArray,
index: usize,
_ctx: &mut ExecutionCtx,
) -> VortexResult<Scalar> {
let decompressed = array.slice(index..index + 1)?.to_primitive();
decompressed.scalar_at(0)
}
Expand Down
3 changes: 2 additions & 1 deletion encodings/fastlanes/src/for/vtable/operations.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
// SPDX-License-Identifier: Apache-2.0
// SPDX-FileCopyrightText: Copyright the Vortex contributors

use vortex_array::ExecutionCtx;
use vortex_array::match_each_integer_ptype;
use vortex_array::scalar::Scalar;
use vortex_array::vtable::OperationsVTable;
Expand All @@ -11,7 +12,7 @@ use super::FoR;
use crate::FoRArray;

impl OperationsVTable<FoR> for FoR {
fn scalar_at(array: &FoRArray, index: usize) -> VortexResult<Scalar> {
fn scalar_at(array: &FoRArray, index: usize, _ctx: &mut ExecutionCtx) -> VortexResult<Scalar> {
let encoded_pvalue = array.encoded().scalar_at(index)?;
let encoded_pvalue = encoded_pvalue.as_primitive();
let reference = array.reference_scalar();
Expand Down
3 changes: 2 additions & 1 deletion encodings/fastlanes/src/rle/vtable/operations.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
// SPDX-License-Identifier: Apache-2.0
// SPDX-FileCopyrightText: Copyright the Vortex contributors

use vortex_array::ExecutionCtx;
use vortex_array::scalar::Scalar;
use vortex_array::vtable::OperationsVTable;
use vortex_error::VortexExpect;
Expand All @@ -11,7 +12,7 @@ use crate::FL_CHUNK_SIZE;
use crate::RLEArray;

impl OperationsVTable<RLE> for RLE {
fn scalar_at(array: &RLEArray, index: usize) -> VortexResult<Scalar> {
fn scalar_at(array: &RLEArray, index: usize, _ctx: &mut ExecutionCtx) -> VortexResult<Scalar> {
let offset_in_chunk = array.offset();
let chunk_relative_idx = array.indices().scalar_at(offset_in_chunk + index)?;

Expand Down
2 changes: 1 addition & 1 deletion encodings/fsst/public-api.lock
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ pub fn vortex_fsst::FSST::with_children(array: &mut Self::Array, children: alloc

impl vortex_array::vtable::operations::OperationsVTable<vortex_fsst::FSST> for vortex_fsst::FSST

pub fn vortex_fsst::FSST::scalar_at(array: &vortex_fsst::FSSTArray, index: usize) -> vortex_error::VortexResult<vortex_array::scalar::Scalar>
pub fn vortex_fsst::FSST::scalar_at(array: &vortex_fsst::FSSTArray, index: usize, _ctx: &mut vortex_array::executor::ExecutionCtx) -> vortex_error::VortexResult<vortex_array::scalar::Scalar>

impl vortex_array::vtable::validity::ValidityChild<vortex_fsst::FSST> for vortex_fsst::FSST

Expand Down
3 changes: 2 additions & 1 deletion encodings/fsst/src/ops.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
// SPDX-License-Identifier: Apache-2.0
// SPDX-FileCopyrightText: Copyright the Vortex contributors

use vortex_array::ExecutionCtx;
use vortex_array::arrays::varbin::varbin_scalar;
use vortex_array::scalar::Scalar;
use vortex_array::vtable::OperationsVTable;
Expand All @@ -12,7 +13,7 @@ use crate::FSST;
use crate::FSSTArray;

impl OperationsVTable<FSST> for FSST {
fn scalar_at(array: &FSSTArray, index: usize) -> VortexResult<Scalar> {
fn scalar_at(array: &FSSTArray, index: usize, _ctx: &mut ExecutionCtx) -> VortexResult<Scalar> {
let compressed = array.codes().scalar_at(index)?;
let binary_datum = compressed.as_binary().value().vortex_expect("non-null");

Expand Down
2 changes: 1 addition & 1 deletion encodings/pco/public-api.lock
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ pub fn vortex_pco::Pco::with_children(array: &mut Self::Array, children: alloc::

impl vortex_array::vtable::operations::OperationsVTable<vortex_pco::Pco> for vortex_pco::Pco

pub fn vortex_pco::Pco::scalar_at(array: &vortex_pco::PcoArray, index: usize) -> vortex_error::VortexResult<vortex_array::scalar::Scalar>
pub fn vortex_pco::Pco::scalar_at(array: &vortex_pco::PcoArray, index: usize, _ctx: &mut vortex_array::executor::ExecutionCtx) -> vortex_error::VortexResult<vortex_array::scalar::Scalar>

pub struct vortex_pco::PcoArray

Expand Down
2 changes: 1 addition & 1 deletion encodings/pco/src/array.rs
Original file line number Diff line number Diff line change
Expand Up @@ -573,7 +573,7 @@ impl ValiditySliceHelper for PcoArray {
}

impl OperationsVTable<Pco> for Pco {
fn scalar_at(array: &PcoArray, index: usize) -> VortexResult<Scalar> {
fn scalar_at(array: &PcoArray, index: usize, _ctx: &mut ExecutionCtx) -> VortexResult<Scalar> {
let mut ctx = LEGACY_SESSION.create_execution_ctx();
array
._slice(index, index + 1)
Expand Down
2 changes: 1 addition & 1 deletion encodings/runend/public-api.lock
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ pub fn vortex_runend::RunEnd::with_children(array: &mut Self::Array, children: a

impl vortex_array::vtable::operations::OperationsVTable<vortex_runend::RunEnd> for vortex_runend::RunEnd

pub fn vortex_runend::RunEnd::scalar_at(array: &vortex_runend::RunEndArray, index: usize) -> vortex_error::VortexResult<vortex_array::scalar::Scalar>
pub fn vortex_runend::RunEnd::scalar_at(array: &vortex_runend::RunEndArray, index: usize, _ctx: &mut vortex_array::executor::ExecutionCtx) -> vortex_error::VortexResult<vortex_array::scalar::Scalar>

impl vortex_array::vtable::validity::ValidityVTable<vortex_runend::RunEnd> for vortex_runend::RunEnd

Expand Down
7 changes: 6 additions & 1 deletion encodings/runend/src/ops.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
// SPDX-FileCopyrightText: Copyright the Vortex contributors

use vortex_array::ArrayRef;
use vortex_array::ExecutionCtx;
use vortex_array::scalar::PValue;
use vortex_array::scalar::Scalar;
use vortex_array::search_sorted::SearchResult;
Expand All @@ -14,7 +15,11 @@ use crate::RunEnd;
use crate::RunEndArray;

impl OperationsVTable<RunEnd> for RunEnd {
fn scalar_at(array: &RunEndArray, index: usize) -> VortexResult<Scalar> {
fn scalar_at(
array: &RunEndArray,
index: usize,
_ctx: &mut ExecutionCtx,
) -> VortexResult<Scalar> {
array.values().scalar_at(array.find_physical_index(index)?)
}
}
Expand Down
2 changes: 1 addition & 1 deletion encodings/sequence/public-api.lock
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ pub fn vortex_sequence::Sequence::with_children(_array: &mut Self::Array, childr

impl vortex_array::vtable::operations::OperationsVTable<vortex_sequence::Sequence> for vortex_sequence::Sequence

pub fn vortex_sequence::Sequence::scalar_at(array: &vortex_sequence::SequenceArray, index: usize) -> vortex_error::VortexResult<vortex_array::scalar::Scalar>
pub fn vortex_sequence::Sequence::scalar_at(array: &vortex_sequence::SequenceArray, index: usize, _ctx: &mut vortex_array::executor::ExecutionCtx) -> vortex_error::VortexResult<vortex_array::scalar::Scalar>

impl vortex_array::vtable::validity::ValidityVTable<vortex_sequence::Sequence> for vortex_sequence::Sequence

Expand Down
6 changes: 5 additions & 1 deletion encodings/sequence/src/array.rs
Original file line number Diff line number Diff line change
Expand Up @@ -409,7 +409,11 @@ impl VTable for Sequence {
}

impl OperationsVTable<Sequence> for Sequence {
fn scalar_at(array: &SequenceArray, index: usize) -> VortexResult<Scalar> {
fn scalar_at(
array: &SequenceArray,
index: usize,
_ctx: &mut ExecutionCtx,
) -> VortexResult<Scalar> {
Scalar::try_new(
array.dtype().clone(),
Some(ScalarValue::Primitive(array.index_value(index))),
Expand Down
2 changes: 1 addition & 1 deletion encodings/sparse/public-api.lock
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ pub fn vortex_sparse::Sparse::with_children(array: &mut Self::Array, children: a

impl vortex_array::vtable::operations::OperationsVTable<vortex_sparse::Sparse> for vortex_sparse::Sparse

pub fn vortex_sparse::Sparse::scalar_at(array: &vortex_sparse::SparseArray, index: usize) -> vortex_error::VortexResult<vortex_array::scalar::Scalar>
pub fn vortex_sparse::Sparse::scalar_at(array: &vortex_sparse::SparseArray, index: usize, _ctx: &mut vortex_array::executor::ExecutionCtx) -> vortex_error::VortexResult<vortex_array::scalar::Scalar>

impl vortex_array::vtable::validity::ValidityVTable<vortex_sparse::Sparse> for vortex_sparse::Sparse

Expand Down
7 changes: 6 additions & 1 deletion encodings/sparse/src/ops.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
// SPDX-License-Identifier: Apache-2.0
// SPDX-FileCopyrightText: Copyright the Vortex contributors

use vortex_array::ExecutionCtx;
use vortex_array::scalar::Scalar;
use vortex_array::vtable::OperationsVTable;
use vortex_error::VortexResult;
Expand All @@ -9,7 +10,11 @@ use crate::Sparse;
use crate::SparseArray;

impl OperationsVTable<Sparse> for Sparse {
fn scalar_at(array: &SparseArray, index: usize) -> VortexResult<Scalar> {
fn scalar_at(
array: &SparseArray,
index: usize,
_ctx: &mut ExecutionCtx,
) -> VortexResult<Scalar> {
Ok(array
.patches()
.get_patched(index)?
Expand Down
2 changes: 1 addition & 1 deletion encodings/zigzag/public-api.lock
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ pub fn vortex_zigzag::ZigZag::with_children(array: &mut Self::Array, children: a

impl vortex_array::vtable::operations::OperationsVTable<vortex_zigzag::ZigZag> for vortex_zigzag::ZigZag

pub fn vortex_zigzag::ZigZag::scalar_at(array: &vortex_zigzag::ZigZagArray, index: usize) -> vortex_error::VortexResult<vortex_array::scalar::Scalar>
pub fn vortex_zigzag::ZigZag::scalar_at(array: &vortex_zigzag::ZigZagArray, index: usize, _ctx: &mut vortex_array::executor::ExecutionCtx) -> vortex_error::VortexResult<vortex_array::scalar::Scalar>

impl vortex_array::vtable::validity::ValidityChild<vortex_zigzag::ZigZag> for vortex_zigzag::ZigZag

Expand Down
6 changes: 5 additions & 1 deletion encodings/zigzag/src/array.rs
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,11 @@ impl ZigZagArray {
}

impl OperationsVTable<ZigZag> for ZigZag {
fn scalar_at(array: &ZigZagArray, index: usize) -> VortexResult<Scalar> {
fn scalar_at(
array: &ZigZagArray,
index: usize,
_ctx: &mut ExecutionCtx,
) -> VortexResult<Scalar> {
let scalar = array.encoded().scalar_at(index)?;
if scalar.is_null() {
return scalar.primitive_reinterpret_cast(array.ptype());
Expand Down
2 changes: 1 addition & 1 deletion encodings/zstd/public-api.lock
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ pub fn vortex_zstd::Zstd::with_children(array: &mut Self::Array, children: alloc

impl vortex_array::vtable::operations::OperationsVTable<vortex_zstd::Zstd> for vortex_zstd::Zstd

pub fn vortex_zstd::Zstd::scalar_at(array: &vortex_zstd::ZstdArray, index: usize) -> vortex_error::VortexResult<vortex_array::scalar::Scalar>
pub fn vortex_zstd::Zstd::scalar_at(array: &vortex_zstd::ZstdArray, index: usize, _ctx: &mut vortex_array::executor::ExecutionCtx) -> vortex_error::VortexResult<vortex_array::scalar::Scalar>

pub struct vortex_zstd::ZstdArray

Expand Down
Loading
Loading