Address chunk size issue in wh_Client_SheSecureBoot#293
Merged
bigbrett merged 2 commits intowolfSSL:mainfrom Mar 5, 2026
Merged
Address chunk size issue in wh_Client_SheSecureBoot#293bigbrett merged 2 commits intowolfSSL:mainfrom
bigbrett merged 2 commits intowolfSSL:mainfrom
Conversation
padelsbach
force-pushed
the
padelsbach/finding-146
branch
16 times, most recently
from
9d9d6b6 to
6a06299
Compare
padelsbach
commented
Mar 2, 2026
padelsbach
commented
Mar 2, 2026
padelsbach
commented
Mar 2, 2026
bigbrett
requested changes
Mar 3, 2026
Contributor
bigbrett
left a comment
bigbrett
left a comment
There was a problem hiding this comment.
Thanks @padelsbach a few fixes required before we can merge.
Also, can you please run git-clang-format main and commit the formatting changes as a separate step?
padelsbach
force-pushed
the
padelsbach/finding-146
branch
4 times, most recently
from
69cedcf to
4110b9b
Compare
padelsbach
force-pushed
the
padelsbach/finding-146
branch
from
4110b9b to
a018af2
Compare
Contributor
Author
|
@bigbrett, I think I addressed all of the comments. I ran |
bigbrett
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes finding 146 and adds associated regression test. Also, this adjusts a buffer size constant in the test code.