Skip to content

Address chunk size issue in wh_Client_SheSecureBoot #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bigbrett merged 2 commits into from
Mar 5, 2026
Merged

Address chunk size issue in wh_Client_SheSecureBoot #293

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a018af2
Address chunk size issue in wh_Client_SheSecureBoot
padelsbach Mar 3, 2026
8a1da7a
Apply git-clang-format
padelsbach Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/wh_client_she.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,9 @@ int wh_Client_SheSecureBoot(whClientContext* c, uint8_t* bootloader,
while (ret == 0 && bootloaderSent < bootloaderLen) {
uint8_t* in;
uint32_t justSent;
uint32_t remaining;
static const uint32_t maxChunk =
WOLFHSM_CFG_COMM_DATA_LEN - sizeof(*updateReq);

if (initResp->rc != WH_SHE_ERC_NO_ERROR) {
return initResp->rc;
Expand All @@ -168,8 +171,8 @@ int wh_Client_SheSecureBoot(whClientContext* c, uint8_t* bootloader,
in = (uint8_t*)(updateReq + 1);

/* send what's left in the size available */
updateReq->sz = ((bootloaderLen - bootloaderSent) %
(WOLFHSM_CFG_COMM_DATA_LEN - sizeof(*updateReq)));
remaining = bootloaderLen - bootloaderSent;
updateReq->sz = (remaining > maxChunk) ? maxChunk : remaining;

justSent = updateReq->sz;
memcpy(in, bootloader + bootloaderSent, updateReq->sz);
Expand Down
Loading