Ensure the length computed by CheckHeaders in the SSL sniffer does not exceed the actual size of the packets.#9947
Conversation
There was a problem hiding this comment.
Pull request overview
Prevents the SSL sniffer’s CheckHeaders length calculation from reporting more SSL bytes than are actually available in the captured packet, avoiding out-of-bounds parsing.
Changes:
- Added a bounds check to ensure
*sslBytesdoes not exceed the remaining captured packet length. - On mismatch, sets an error and returns
WOLFSSL_FATAL_ERROR.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Retest this please. |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
|
Retest this please. |
|
Retest this please Jenkins. Multi-test failed but the history of the issue is no longer available, there is a high chance it is a actual adjustment that needs to be made to this PR. |
…t exceed the actual size of the packets. Thanks to Haruto Kimura (Stella) for the report.
|
Retest this please Jenkins. Windows test failure |
Description
Fixes zd#21325
Thanks to Haruto Kimura (Stella) for the report.
Testing
Provided reproducer + built in tests
Checklist