Skip to content

Ensure the length computed by CheckHeaders in the SSL sniffer does not exceed the actual size of the packets. #9947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JacobBarthelmeh merged 2 commits into from
Mar 13, 2026
Merged

Ensure the length computed by CheckHeaders in the SSL sniffer does not exceed the actual size of the packets. #9947

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
19b99f8
Ensure the length computed by CheckHeaders in the SSL sniffer does no…
kareem-wolfssl Mar 10, 2026
94b370f
Rework check to compare only ints.
kareem-wolfssl Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/sniffer.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5520,6 +5520,12 @@ static int CheckHeaders(IpInfo* ipInfo, TcpInfo* tcpInfo, const byte* packet,
* data after the IP record for the FCS for Ethernet. */
*sslBytes = (int)(packet + ipInfo->total - *sslFrame);

/* Ensure sslBytes does not exceed the actual size. */
if (*sslBytes > (int)(length - (ipInfo->length + tcpInfo->length))) {
SetError(PACKET_HDR_SHORT_STR, error, NULL, 0);
return WOLFSSL_FATAL_ERROR;
}

(void)checkReg;

return 0;
Expand Down
Loading