Skip to content

chore: mark release tools as Bash scripts - #13

Merged
robjtede merged 2 commits into
mainfrom
bash-release-tools
Aug 9, 2026
Merged

chore: mark release tools as Bash scripts#13
robjtede merged 2 commits into
mainfrom
bash-release-tools

Conversation

@robjtede

@robjtede robjtede commented Aug 9, 2026

Copy link
Copy Markdown
Member

Summary

  • rename release tooling scripts from .sh to .bash to make their Bash-only implementation explicit
  • enable inherit_errexit for the release tools and their Bash test fixtures
  • update the Nix flake references

Validation

  • nix flake check path:.
  • git diff --check

Summary by CodeRabbit

  • Bug Fixes
    • Improved release tooling reliability by preserving error handling in shell command substitutions.
    • Renamed release-tool scripts to use the .bash extension.
    • Updated release-tool checks to validate the renamed test script.
    • Added ShellCheck coverage for all release-tool Bash scripts.

@coderabbitai

coderabbitai Bot commented Aug 9, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 22ebbc0f-064b-44be-a9eb-ab4579410f14

📥 Commits

Reviewing files that changed from the base of the PR and between f6439ce and 9b0a684.

📒 Files selected for processing (6)
  • flake.nix
  • release-tools/bump-changelogs.bash
  • release-tools/comment-release-assets-uploaded.bash
  • release-tools/comment-release-pr.bash
  • release-tools/test.bash
  • release-tools/update-release-notes.bash

📝 Walkthrough

Walkthrough

Release tooling now uses .bash script names, preserves errexit in command substitutions, and checks all release-tool Bash scripts with ShellCheck.

Changes

Release tool Bash migration

Layer / File(s) Summary
Bash error handling
release-tools/*.bash
Release scripts and fake test executables enable Bash inherit_errexit.
Release tool checks and wiring
flake.nix
Release commands reference .bash scripts. The release-tools check runs test.bash and adds ShellCheck coverage for all .bash files.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

  • x52dev/nix#1: Updates the same release-tools scripts, test fixture, and flake.nix for .bash naming, inherit_errexit, and ShellCheck coverage.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the primary change: renaming the release tools to identify them as Bash scripts.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bash-release-tools

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@robjtede
robjtede force-pushed the bash-release-tools branch from f82654f to 9b0a684 Compare August 9, 2026 15:34
@robjtede
robjtede marked this pull request as ready for review August 9, 2026 16:18
@robjtede
robjtede merged commit d568f68 into main Aug 9, 2026
3 checks passed
@robjtede
robjtede deleted the bash-release-tools branch August 9, 2026 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant