chore: mark release tools as Bash scripts

flake.nix

@@ -52,7 +52,7 @@
               pkgs.gnused
               pkgs.jq
             ];
-            text = builtins.readFile ./release-tools/bump-changelogs.sh;
+            text = builtins.readFile ./release-tools/bump-changelogs.bash;
           };
 
           x52-update-release-notes = pkgs.writeShellApplication {
@@ -64,7 +64,7 @@
               pkgs.git
               pkgs.jq
             ];
-            text = builtins.readFile ./release-tools/update-release-notes.sh;
+            text = builtins.readFile ./release-tools/update-release-notes.bash;
           };
 
           x52-comment-release-pr = pkgs.writeShellApplication {
@@ -74,7 +74,7 @@
               pkgs.gh
               pkgs.jq
             ];
-            text = builtins.readFile ./release-tools/comment-release-pr.sh;
+            text = builtins.readFile ./release-tools/comment-release-pr.bash;
           };
 
           x52-comment-release-assets-uploaded = pkgs.writeShellApplication {
@@ -84,7 +84,7 @@
               pkgs.gh
               pkgs.jq
             ];
-            text = builtins.readFile ./release-tools/comment-release-assets-uploaded.sh;
+            text = builtins.readFile ./release-tools/comment-release-assets-uploaded.bash;
           };
 
           x52-release-tools = pkgs.symlinkJoin {
@@ -117,7 +117,17 @@
                   BASH_BIN = "${pkgs.bash}/bin/bash";
                 }
                 ''
-                  bash ${./release-tools/test.sh}
+                  bash ${./release-tools/test.bash}
+                  touch "$out"
+                '';
+
+            shellcheck =
+              pkgs.runCommand "check-shellcheck"
+                {
+                  nativeBuildInputs = [ pkgs.shellcheck ];
+                }
+                ''
+                  shellcheck ${./release-tools}/*.bash
                   touch "$out"
                 '';
 

release-tools/bump-changelogs.sh → release-tools/bump-changelogs.bash

@@ -1,4 +1,5 @@
 set -eEuo pipefail
+shopt -s inherit_errexit
 
 release_plz_pr_json="${RELEASE_PLZ_PR_JSON:?RELEASE_PLZ_PR_JSON is required}"
 cargo_bin="${X52_CARGO:-cargo}"

release-tools/comment-release-assets-uploaded.sh → release-tools/comment-release-assets-uploaded.bash

@@ -1,4 +1,5 @@
 set -eEuo pipefail
+shopt -s inherit_errexit
 
 release_plz_releases_json="${1:?release-plz releases JSON is required}"
 marker="<!-- x52-release-assets-uploaded -->"

release-tools/comment-release-pr.sh → release-tools/comment-release-pr.bash

@@ -1,4 +1,5 @@
 set -eEuo pipefail
+shopt -s inherit_errexit
 
 release_plz_releases_json="${1:?release-plz releases JSON is required}"
 marker="<!-- x52-draft-release-link -->"

release-tools/test.sh → release-tools/test.bash

@@ -1,4 +1,5 @@
 set -euo pipefail
+shopt -s inherit_errexit
 
 test_root="$(mktemp -d)"
 trap 'rm -rf "$test_root"' EXIT
@@ -36,13 +37,15 @@ EOF
 printf '#!%s\n' "$bash_bin" >"$fake_bin/cargo"
 cat >>"$fake_bin/cargo" <<'EOF'
 set -euo pipefail
+shopt -s inherit_errexit
 [[ "$*" == "metadata --format-version=1 --no-deps" ]]
 printf '{"packages":[{"name":"demo","manifest_path":"%s/Cargo.toml"}]}\n' "$FIXTURE_ROOT"
 EOF
 
 printf '#!%s\n' "$bash_bin" >"$fake_bin/gh"
 cat >>"$fake_bin/gh" <<'EOF'
 set -euo pipefail
+shopt -s inherit_errexit
 printf 'gh' >>"$COMMAND_LOG"
 printf ' <%s>' "$@" >>"$COMMAND_LOG"
 printf '\n' >>"$COMMAND_LOG"
@@ -84,6 +87,7 @@ EOF
 printf '#!%s\n' "$bash_bin" >"$fake_bin/git"
 cat >>"$fake_bin/git" <<'EOF'
 set -euo pipefail
+shopt -s inherit_errexit
 if [[ "$*" == "diff --cached --quiet" ]]; then
     exit 1
 fi

release-tools/update-release-notes.sh → release-tools/update-release-notes.bash

@@ -1,4 +1,5 @@
 set -eEuo pipefail
+shopt -s inherit_errexit
 
 release_plz_releases_json="${RELEASE_PLZ_RELEASES_JSON:?RELEASE_PLZ_RELEASES_JSON is required}"
 cargo_bin="${X52_CARGO:-cargo}"