remove: followFluxes, dead code fully subsumed by printFluxes + followChanged - #725
Merged
Merged
Conversation
Function test results304 tests 277 ✅ 1m 18s ⏱️ Results for commit 2f6977e. |
This was referenced Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Found while auditing
raven_toolboxport-gap issues (SysBioChalmers/raven-gecko-parity#46):followFluxesprints reactions whose flux falls in a range, optionally alongside a second reference flux vector. Nothing it does is missing from RAVEN's own other functions:printFluxes'scutOffFluxargument.followChanged's comparison (which additionally supports percent-change, absolute-value, and difference cutoffs, plus metabolite-based subsetting).Removed the function and its one test reference (
tAnalysis.m'sfollowFluxesRuns, a smoke test). Confirmed no other RAVEN source or test file references it.Test plan
tAnalysistest class: 23/25 passed. The 2 failures (getMinimalMediumReturnsMedium,getMinimalMediumExplicitGrowth) are unrelated to this change — different function entirely, and this diff touches onlyfollowFluxes.m(deleted) and one unrelated test function's removal fromtAnalysis.m.