Skip to content

chore: add dev tools to mise.toml, remove redundant CI installs - #1386

Merged
chris-olszewski merged 1 commit into
temporalio:mainfrom
brucearctor:feat/mise-tools
Jul 14, 2026
Merged

chore: add dev tools to mise.toml, remove redundant CI installs#1386
chris-olszewski merged 1 commit into
temporalio:mainfrom
brucearctor:feat/mise-tools

Conversation

@brucearctor

Copy link
Copy Markdown
Contributor

Summary

Add temporal, cargo-component, and cargo-msrv to mise.toml and remove the redundant manual installation steps they replace from CI.

PR 1 of 3 — scoped to the minimal, low-risk change. See #1383 for the full effort.

Changes

mise.toml

Tool Version Replaces
temporal 1.7.2 temporalio/setup-temporal action
cargo:cargo-component 0.21.1 cargo install --locked cargo-component
cargo:cargo-msrv 0.19.3 cargo install cargo-msrv

per-pr.yml (removals only)

  • Remove rustup component add rustfmt clippy (2 places) — already in rust-toolchain.toml
  • Remove cargo install cargo-msrv — now via mise
  • Remove cargo install --locked cargo-component — now via mise
  • Remove temporalio/setup-temporal action — now via mise
  • Add missing cache-bin: false to wasm-workflow-tests rust-cache
  • Remove dead submodules: recursive (2 places) — no submodules exist since Update API protos subtree #194

heavy.yml

  • Remove dead submodules: recursive — same reason

Follow-up PRs

  • PR 2: Extract composite action + selective mise installs (stacked on this PR)
  • PR 3: Add lefthook, mise-bump workflow, README update (independent)

Ref #1383

@brucearctor

Copy link
Copy Markdown
Contributor Author

I see CI Fail. Digging into that

- Add temporal 1.7.2, cargo-component 0.21.1, cargo-msrv 0.19.3
  to mise.toml (versions pinned per 2-week minimum age policy)
- Remove redundant 'rustup component add rustfmt clippy' (2 places)
  Already declared in rust-toolchain.toml components
- Remove 'cargo install cargo-msrv' (now via mise)
- Remove 'cargo install --locked cargo-component' (now via mise)
- Remove 'temporalio/setup-temporal' action (now via mise)
- Add missing 'cache-bin: false' to wasm-workflow-tests rust-cache
- Remove dead 'submodules: recursive' (3 places, no submodules exist)

Closes temporalio#1383
@chris-olszewski
chris-olszewski merged commit 208ca8b into temporalio:main Jul 14, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants